[tp-devel] [tp-cvs] libtpproto-java (midp) - Removed String.Format from all these classes, also replaced some for-each loops with for loops. All string buffer issues have been replaced to use default string functions. Finally, some generics that were missed have been removed. Very few errors remain in the majority of classes

[tp-devel] [tp-cvs] libtpproto-java (midp) - Removed String.Format from all these classes, also replaced some for-each loops with for loops. All string buffer issues have been replaced to use default string functions. Finally, some generics that were missed have been removed. Very few errors remain in the majority of classes

Roberts, Brendan Matthew - robbm005 robbm005 at students.unisa.edu.au
Tue May 13 02:44:42 EDT 2008


Can't believe i missed that one, thanks.
My current plan is to implement it in the generated code and then apply it back to the generator. A little extra work, but it allows me to understand what I'm doing a little bit better.

I'm currently stuck on the issue of no 'FilterInputStream' being present in MIDP, it is used in net.thousandparsec.netlib/LimitInputStream, are there possible alternatives available that you are aware of? 

Thanks


-----Original Message-----
From: tp-devel-bounces at thousandparsec.net on behalf of Krzysztof Sobolewski
Sent: Mon 5/12/2008 8:28 PM
To: tp-devel at thousandparsec.net
Subject: Re: [tp-devel] [tp-cvs] libtpproto-java (midp) - Removed String.Format from all	these classes, also replaced some for-each loops with for loops. All string buffer	issues have been replaced to use default string functions. Finally, some generics that were missed have been removed. Very few errors remain in the majority of classes
 
Brendan Matthew Roberts pisze:
> --- a/src-generated/net/thousandparsec/netlib/tp03/AddCategory.java
> +++ b/src-generated/net/thousandparsec/netlib/tp03/AddCategory.java
> @@ -51,11 +51,7 @@ public class AddCategory extends Category
>  
>  	public String toString()
>  	{
> -		StringBuilder buf=new StringBuilder();
> -		buf.append("{AddCategory");
> -		buf.append("; super:").append(super.toString());
> -		buf.append("}");
> -		return buf.toString();
> +                return "(AddCategory; super:" +super.toString()+")";
>  	}
>  
>  }

I admire all this laborious replacing, but that wasn't necessary, I'm
afraid... First, these files are automatically generated, so it would be
much faster to modify the generator (and that's true for all types of
changes), and second, it's enough here to simply replace StringBuilder with
StringBuffer (I assume StringBuffer is in midp).
-- 
KS
"To an engineer, everyone looks like a chimp" - Dilbert


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/ms-tnef
Size: 5311 bytes
Desc: not available
Url : http://mail.thousandparsec.net/pipermail/tp-devel/attachments/20080513/193b307a/attachment.bin 


More information about the tp-devel mailing list